adoroszlai commented on a change in pull request #3052:
URL: https://github.com/apache/ozone/pull/3052#discussion_r813237638
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java
##########
@@ -109,27 +111,31 @@
}
}
- private void extractEntry(InputStream input, long size,
- Path ancestor, Path path) throws IOException {
+ private void extractEntry(ArchiveEntry entry, InputStream input, long size,
+ Path ancestor, Path path) throws IOException {
HddsUtils.validatePath(path, ancestor);
Path parent = path.getParent();
if (parent != null) {
Files.createDirectories(parent);
}
Review comment:
Nit: we could move this inside the `else` branch, since in the `if`
branch `createDirectories(path)` would take care of parent directories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
