siddhantsangwan commented on pull request #3129: URL: https://github.com/apache/ozone/pull/3129#issuecomment-1049517855
@symious Thanks for the review! > I think the maxSizeToMovePerIteration and maxDatanodesPercentageToInvolvePerIteration are more like ITERATION_STOP_REASON other than ITERATION_RESULT. Maybe we can add a new field noting the reason and mark the result as COMPLETE if encounter a valid STOP_REASON? Makes sense. This is an alternative that I was thinking of - We can just mark the result as `ITERATION_COMPLETED` when the max size or max DNs limit is hit. Should we have only two possible results for an iteration, then? Such as `ITERATION_COMPLETED` and `ITERATION_STOPPED`. The rest can be logged as reasons for stopping the iteration as you're suggesting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
