rakeshadr commented on a change in pull request #3134:
URL: https://github.com/apache/ozone/pull/3134#discussion_r813808672
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyDeleteRequestWithFSO.java
##########
@@ -39,6 +39,10 @@
* Tests OmKeyDelete request with prefix layout.
*/
public class TestOMKeyDeleteRequestWithFSO extends TestOMKeyDeleteRequest {
+ private static final String PARTIAL_PARENT_DIR = "c/d/";
Review comment:
please rename var name : `PARTIAL_PARENT_DIR` ->` INTERMEDIATE_DIR`
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyDeleteRequestWithFSO.java
##########
@@ -132,4 +149,68 @@ private void verifyPath(OzonePrefixPath ozonePrefixPath,
String pathName,
// expected
}
}
+
+ @Test
+ public void testRecursiveAccessCheck() throws Exception {
+ // Add volume, bucket and key entries to OM DB.
+ OMRequestTestUtils.addVolumeAndBucketToDB(volumeName, bucketName,
+ omMetadataManager, getBucketLayout());
+
+ // Case 1:
+ // We create an empty directory structure.
+ String partialKey = "x/y/";
Review comment:
rename `partialKey` to -> either `intermediateDir` or `parentKey`. Also,
please update the java comments by replacing `partial`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
