k5342 commented on pull request #3088: URL: https://github.com/apache/ozone/pull/3088#issuecomment-1053304990
I've rebased to fix conflicts. @avijayanhwx Could you help to review this PR? IMO, we don't have to put a cache here. This is a trade-off between the DB load and time-resolution. I think N seconds polling is small enough load and acceptable. From a security standpoint, I think the load is from internal metrics system only (means not to be published as external API because `/prom` is protected, malformed access or F5-attack can be ignored). So it is expected to be small as well and we can take time-resolution in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
