kaijchen commented on pull request #3151: URL: https://github.com/apache/ozone/pull/3151#issuecomment-1057097235
> Is this refactor adding any features or fixing any bugs? As it stands we are still trying to stabilise the code - these sort of changes to make it "cleaner" take time to review and risk adding more problems, especially when the test suite is not covering all possible scenarios. No, this PR does not suppose to change code logic. I agree with your point. We can revisit this later if there is a need. For example, we are going to implement cell rotation feature and minimum required write feature later. It will be easier to change fewer places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
