dombizita opened a new pull request #3158: URL: https://github.com/apache/ozone/pull/3158
## What changes were proposed in this pull request? In this change I modified the currentPipelineCount() method. I found that when the method calculated the current pipeline count in a datanode it counted in the STANDALONE pipelines. We shouldn't count the single node pipelines in, only the RATIS/THREE ones. So I renamed the method to currentRatisThreePipelineCount() and changed it to count the datanodes non closed RATIS/THREE pipelines. With this I fixed the problem, when we reached the pipeline limit with STANDALONE/ONE pipelines so it didn't create a RATIS/THREE pipeline. With the modified method some tests started failing in the TestPipelinePlacementPolicy. It was because some tests are using the insertHeavyNodesIntoNodeManager method which were only inserting the datanodes and its pipelines into the nodeManager and not into the pipelineStateManager. This wasn't a problem before because when we didn't find a pipeline in the pipelineStateManager we continued with the next pipeline, we didn't deducted that pipeline as a non single node pipeline, so we simply calculated it as a good one. Because of this I changed the insertHeavyNodesIntoNodeManager method to also add the pipelines to the pipelineStateManager. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-6379 ## How was this patch tested? Added unit tests to the modified method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
