hanishakoneru commented on pull request #2901: URL: https://github.com/apache/ozone/pull/2901#issuecomment-1058492345
Thanks @neils-dev for working on this. IIUC _GrpcOmTransport_ only needs the retryPolicy from _OMFailoverProxyProvider_. Do we really need to have _GrpcOMFailoverProxyProvider_ implement _OMFailoverProxyProvider_? For keeping the same underlying failover proxy, instead of _GrpcOMFailoverProxyProvider_ implementing _OMFailoverProxyProvider_, there should be a base interface/ class that these two can can implement. Setting null values to the proxy maps does not seem right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
