umamaheswararao commented on a change in pull request #3128:
URL: https://github.com/apache/ozone/pull/3128#discussion_r819210873
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockOutputStreamEntry.java
##########
@@ -338,30 +334,16 @@ private boolean isFailed(
= null;
try {
containerCommandResponseProto = chunkWriteResponseFuture != null ?
- chunkWriteResponseFuture.get() :
- null;
+ chunkWriteResponseFuture.get() : null;
} catch (InterruptedException e) {
outputStream.setIoException(e);
Thread.currentThread().interrupt();
} catch (ExecutionException e) {
outputStream.setIoException(e);
}
- if ((outputStream != null && containerCommandResponseProto != null)
- && (outputStream.getIoException() != null || isStreamFailed(
- containerCommandResponseProto, outputStream))) {
- return true;
- }
- return false;
- }
-
- boolean isStreamFailed(
- ContainerProtos.ContainerCommandResponseProto responseProto,
- ECBlockOutputStream stream) {
- try {
- ContainerProtocolCalls.validateContainerResponse(responseProto);
- } catch (StorageContainerException sce) {
- stream.setIoException(sce);
+ if (containerCommandResponseProto != null
Review comment:
I think there are cases when this response can be null ( I am not 100%
sure, what case it will be null). In the case of null also, should we consider
stream as failed?
@cchenax faced an issue and in his debug logs he was claiming one of future
response was null. SO, we may need to rethink here, what if response future
null?
And let's add some debug info in this response handling path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
