sodonnel opened a new pull request #3165: URL: https://github.com/apache/ozone/pull/3165
## What changes were proposed in this pull request? There is generally a RatisReplicationConfig object stored in each ContainerInfo in SCM, and in each Pipeline too. New instances of the Ratis and Standalone objects are scattered throughout the code and used extensively in the tests. Each object is basically identical - it only contains the factor, or ONE or THREE. We can save some memory and object churn if we just return a static value each time someone requests a Standalone/RatisReplicationConfig object. Unfortunately this PR is quite large. I have split it into 3 commits: 1) Makes the changes in the non-test classes - the changes here are fairly small. 2) Replaces `new RatisReplicationConfig()` across the tests and make the constructor private 3) Replaces `new StandalineReplicationConfig()` across the tests makes the constructor private The diff is large due to the number of places the replacement happens, but there is no logic change - its just a global replace and then some tidy up for checkstyle line lengths. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-6420 ## How was this patch tested? Existing tests - not real functionality changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
