ghuangups commented on a change in pull request #3148: URL: https://github.com/apache/ozone/pull/3148#discussion_r819944302
########## File path: hadoop-hdds/test-utils/src/main/java/org/apache/ozone/test/tag/Flaky.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.ozone.test.tag; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +import org.junit.jupiter.api.Tag; + +/** + * Annotation to mark test classes or methods with some intermittent failures. + * These are handled separately from the normal tests. (Not required to pass, + * may be repeated automatically, etc.) + */ +@Target({ ElementType.TYPE, ElementType.METHOD }) +@Retention(RetentionPolicy.RUNTIME) +@Tag("flaky") +public @interface Flaky { Review comment: Thanks @adoroszlai for the great explanation. Yes, sure, regarding the current categories implementation. Regarding the tagging, how about using a small tool to do the tagging at run time based on the text file for test listing? My concern is the sustainability. For example, any test fix or moving between categories or the like will involve code level changes and go through whole CI process. On the other hand, if we have a text file based list, that could be a lot light-weighted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
