[ 
https://issues.apache.org/jira/browse/HDDS-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503934#comment-17503934
 ] 

Neil Joshi commented on HDDS-6433:
----------------------------------

Thanks [~hanishakoneru]  for creating this Jira to track this.  I would like to 
look at the refactoring applied to the master branch and not this feature 
branch, thoughts on this?

> Refactor OMFailoverProxyProvider to provide a base for OM and GrpcOM 
> FailoverProxyProviders
> -------------------------------------------------------------------------------------------
>
>                 Key: HDDS-6433
>                 URL: https://issues.apache.org/jira/browse/HDDS-6433
>             Project: Apache Ozone
>          Issue Type: Sub-task
>            Reporter: Hanisha Koneru
>            Priority: Major
>
> HDDS-5544 added GrpcOMFailoverProxyProvider which implements 
> OMFailoverProxyProvider but it does not need most of the logic in 
> OMFailoverProxyProvider and sets some map values as null as it is not 
> required for Grpc. 
> For keeping the same underlying failover proxy, instead of 
> GrpcOMFailoverProxyProvider implementing OMFailoverProxyProvider, there 
> should be a base interface/ class that these two can can implement. 
> Please refer to 
> [this|https://github.com/apache/ozone/pull/2901#issuecomment-1058492345] 
> comment in HDDS-5544.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to