xBis7 opened a new pull request #3183: URL: https://github.com/apache/ozone/pull/3183
## What changes were proposed in this pull request? There has been implemented a new "write-path" for OzoneManager but many of the BucketManager tests still call the old "write-path" methods. In this PR the obsolete code for the methods performing writes in BucketManager and BucketManagerImpl classes was removed. Such methods include createBucket(), deleteBucket() and setBucketProperty(). There have also been changes in all the tests in TestBucketManagerImpl class that were using these methods. Instead of writing and deleting buckets using BucketManager class, now these actions are performed using OzoneManagerProtocol class. Note that this is the same approach taken in the [PR which fixed the keymanager tests](https://github.com/apache/ozone/pull/2961). Specifically, OmMetadataManager, BucketManager and MetadataManager classes are now accessed through OmTestManagers class, invalid volume and bucket names have been fixed and `bucketManager.createBucket(bucketInfo);` has been replaced by `writeClient.createBucket(bucketInfo);`, `bucketManager.setBucketProperty(bucketArgs);` has been replaced by `writeClient.setBucketProperty(bucketArgs);`, `bucketManager.deleteBucket("sampleVol", "bucketOne");` has been replaced by `writeClient.deleteBucket("sample-vol", "bucket-one");` where `writeClient` is of type OzoneManagerProtocol. Finally, in TestBucketManagerImpl class, the new writeClient approach allows us to fix the previously broken tests that were marked with `@Ignore`. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-3370 ## How was this patch tested? All tests now passing, including the ones previously marked `@Ignore` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
