[
https://issues.apache.org/jira/browse/HDDS-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505056#comment-17505056
]
István Fajth commented on HDDS-6418:
------------------------------------
We had multiple discussions already in this topic, I think the current PR
solves this particular problem, we will need to look into this later on when we
are getting to an agreement about how we want to handle these kind of
compatibility problems later on. For now I am good to go, thank you for the
explanation and the discussions we had with others on this topic already. I
have approved the PR in the meantime,
> Datanode usage info uses wrong version number
> ---------------------------------------------
>
> Key: HDDS-6418
> URL: https://issues.apache.org/jira/browse/HDDS-6418
> Project: Apache Ozone
> Issue Type: Bug
> Components: SCM
> Affects Versions: 1.1.0
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Major
> Labels: pull-request-available
>
> {{DatanodeUsageInfo}} passes _datanode_ version
> ({{datanodeDetails.getCurrentVersion()}}) to the {{toProto}} method instead
> of _client_ version.
> {code:title=https://github.com/apache/ozone/blob/fe6f060d8983462a717f6588dff257f4a6da86c4/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeUsageInfo.java#L187-L201}
> private HddsProtos.DatanodeUsageInfoProto.Builder toProtoBuilder() {
> HddsProtos.DatanodeUsageInfoProto.Builder builder =
> HddsProtos.DatanodeUsageInfoProto.newBuilder();
> if (datanodeDetails != null) {
> builder.setNode(
> datanodeDetails.toProto(datanodeDetails.getCurrentVersion()));
> }
> if (scmNodeStat != null) {
> builder.setCapacity(scmNodeStat.getCapacity().get());
> builder.setUsed(scmNodeStat.getScmUsed().get());
> builder.setRemaining(scmNodeStat.getRemaining().get());
> }
> return builder;
> }
> {code}
> CC [~siddhantsangwan], [~ljain]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
