smengcl commented on a change in pull request #3177:
URL: https://github.com/apache/ozone/pull/3177#discussion_r826468123
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDBAccessIdInfo.java
##########
@@ -42,16 +42,19 @@
* Only effective if isAdmin is true.
*/
private final boolean isDelegatedAdmin;
-
- // This implies above String fields should NOT contain the split key.
- public static final String SERIALIZATION_SPLIT_KEY = ";";
+ /**
+ * Role name of the user (that this access ID is assigned to) in this tenant.
+ * e.g. "user", "admin", "auditor"
+ */
+ private final String roleId;
public OmDBAccessIdInfo(String tenantId, String userPrincipal,
- boolean isAdmin, boolean isDelegatedAdmin) {
+ boolean isAdmin, boolean isDelegatedAdmin, String roleId) {
this.tenantId = tenantId;
this.userPrincipal = userPrincipal;
this.isAdmin = isAdmin;
this.isDelegatedAdmin = isDelegatedAdmin;
+ this.roleId = roleId;
Review comment:
Thanks @prashantpogde . Very good point. I have addressed the issue by
making the protobuf a `repeated` one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
