rakeshadr commented on a change in pull request #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r827841330
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
##########
@@ -489,6 +532,29 @@ private boolean innerDelete(Path f, boolean recursive)
throws IOException {
}
}
+ /**
+ * Deletes the children of the bucket i.e all files and dirs under it's
+ * path by iterating though th DeleteIteratorWithFSO.
+ *
+ * @param f directory path to be deleted
+ * @return true if successfully deletes all required keys, false otherwise
+ * @throws IOException
+ */
+ private boolean recursiveBucketDelete(Path f, boolean recursive)
+ throws IOException {
+ LOG.trace("delete() path:{}", f);
+ try {
+ DeleteIteratorWithFSO iterator = new DeleteIteratorWithFSO(f, recursive);
Review comment:
Adding hint based on online discussion with @sadanand48. Here the new
ofs client can set `recursive=true` and at the server side
`OMBucketDeleteRequest` can add logic to handle the
`omMetadataManager.isBucketEmpty` check.
```
message DeleteBucketRequest {
required string volumeName = 1;
required string bucketName = 2;
optional bool recursive = 3 [default = false];
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
