kaijchen edited a comment on pull request #3213: URL: https://github.com/apache/ozone/pull/3213#issuecomment-1072962632
> Thanks @kaijchen for the patch. Thanks @adoroszlai for the review. > Before reporting a problem, please search Jira to see if it is already known and/or being worked on. In this case [HDDS-6470](https://issues.apache.org/jira/browse/HDDS-6470) duplicates [HDDS-6469](https://issues.apache.org/jira/browse/HDDS-6469), reported yesterday. I have ran 100x iterations of the fix overnight. > > I think it is better to verify the fix before opening a PR. One may need to tweak the fix based on results. Waiting with the PR saves both reviewer's time and GitHub resources. Sure, sorry about that. > Running 10x10 iterations instead of 1x100 to get results faster is a good idea. > > Please note that some other test cases in `TestOzoneManagerHAWithData` are also flaky (reported in separate Jira issues). Including these in the 100x repetitions can make it harder to verify results: instead of 100 clean runs we may get other failures. Test can be limited to the specific case by `-Dtest=TestOzoneManagerHAWithData#testOMRestart`. Thanks for the advise. > I also see failure in `testOMRestart` with the patch: https://github.com/kaijchen/ozone/runs/5609898194#step:4:3547 I don't think this failure is related to the change made here. I will rerun the tests. > All in all, I like your patch better than mine. I'll close my PR and merge this one once we get 100x clean runs. The only difference in code logic between these 2 patches is the assertion. I'm good if you wish to merge yours with the assertion included. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
