tanvipenumudy commented on a change in pull request #3180:
URL: https://github.com/apache/ozone/pull/3180#discussion_r830566201
##########
File path:
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
##########
@@ -341,4 +357,66 @@ public void testMultiLockResourceParallel() throws
Exception {
Thread.sleep(100);
Assert.assertTrue(gotLock.get());
}
+
+ @Test
+ public void testLockHoldCount() throws Exception {
+ String[] resourceName;
+ String resourceLockName;
+ for (OzoneManagerLock.Resource resource :
+ OzoneManagerLock.Resource.values()) {
+ // USER_LOCK, S3_SECRET_LOCK and PREFIX_LOCK disallow lock re-acquire by
+ // the same thread.
+ if (resource != OzoneManagerLock.Resource.USER_LOCK &&
+ resource != OzoneManagerLock.Resource.S3_SECRET_LOCK &&
+ resource != OzoneManagerLock.Resource.PREFIX_LOCK) {
+ resourceName = generateResourceName(resource);
+ resourceLockName = generateResourceLockName(resource, resourceName);
+ testLockHoldCountUtil(resource, resourceName, resourceLockName);
+ }
+ }
+ }
+
+ private void testLockHoldCountUtil(OzoneManagerLock.Resource resource,
+ String[] resourceName,
+ String resourceLockName) throws Exception
{
+ OzoneManagerLock lock = new OzoneManagerLock(new OzoneConfiguration());
+
+ assertEquals(0, lock.getHoldCount(resourceLockName));
+
+ lock.acquireReadLock(resource, resourceName);
+ assertEquals(1, lock.getHoldCount(resourceLockName));
+
+ lock.acquireReadLock(resource, resourceName);
+ assertEquals(2, lock.getHoldCount(resourceLockName));
+
+ lock.acquireReadLock(resource, resourceName);
+ assertEquals(3, lock.getHoldCount(resourceLockName));
+
+ lock.releaseReadLock(resource, resourceName);
+ assertEquals(2, lock.getHoldCount(resourceLockName));
+
+ lock.releaseReadLock(resource, resourceName);
+ assertEquals(1, lock.getHoldCount(resourceLockName));
+
+ lock.releaseReadLock(resource, resourceName);
+ assertEquals(0, lock.getHoldCount(resourceLockName));
+
+ lock.acquireWriteLock(resource, resourceName);
+ assertEquals(1, lock.getHoldCount(resourceLockName));
+
+ lock.acquireWriteLock(resource, resourceName);
+ assertEquals(2, lock.getHoldCount(resourceLockName));
+
+ lock.acquireWriteLock(resource, resourceName);
+ assertEquals(3, lock.getHoldCount(resourceLockName));
+
+ lock.releaseWriteLock(resource, resourceName);
+ assertEquals(2, lock.getHoldCount(resourceLockName));
+
+ lock.releaseWriteLock(resource, resourceName);
+ assertEquals(1, lock.getHoldCount(resourceLockName));
+
+ lock.releaseWriteLock(resource, resourceName);
+ assertEquals(0, lock.getHoldCount(resourceLockName));
Review comment:
Thank you for the suggestion, addressed your comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
