sadanand48 commented on a change in pull request #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r831278652
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
##########
@@ -489,6 +532,29 @@ private boolean innerDelete(Path f, boolean recursive)
throws IOException {
}
}
+ /**
+ * Deletes the children of the bucket i.e all files and dirs under it's
+ * path by iterating though th DeleteIteratorWithFSO.
+ *
+ * @param f directory path to be deleted
+ * @return true if successfully deletes all required keys, false otherwise
+ * @throws IOException
+ */
+ private boolean recursiveBucketDelete(Path f, boolean recursive)
+ throws IOException {
+ LOG.trace("delete() path:{}", f);
+ try {
+ DeleteIteratorWithFSO iterator = new DeleteIteratorWithFSO(f, recursive);
Review comment:
Thanks @errose28 for the review.
Yes currently there exists no recursive bucketDelete api call to the OM
,however we can set the default value of recursive to false so that no
operations on object store buckets are affected. The only use case is this
particular case of HDDS-6414 i.e for FSO buckets.
We are choosing this approach only because the approach in the current PR
would create multiple RPC's for the client on a bucket delete thereby
potentially blocking it and the new approach would be an optimized one with
just one delete call.
@errose28 , Please let me know if the approach sounds good.
Anyway I'll create a new PR for the second approach in case anybody has
objections .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
