errose28 commented on a change in pull request #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r831497377
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
##########
@@ -489,6 +532,29 @@ private boolean innerDelete(Path f, boolean recursive)
throws IOException {
}
}
+ /**
+ * Deletes the children of the bucket i.e all files and dirs under it's
+ * path by iterating though th DeleteIteratorWithFSO.
+ *
+ * @param f directory path to be deleted
+ * @return true if successfully deletes all required keys, false otherwise
+ * @throws IOException
+ */
+ private boolean recursiveBucketDelete(Path f, boolean recursive)
+ throws IOException {
+ LOG.trace("delete() path:{}", f);
+ try {
+ DeleteIteratorWithFSO iterator = new DeleteIteratorWithFSO(f, recursive);
Review comment:
Changing this to be handled on the server side in a follow-up PR like
you said sounds good.
> This field is being added to the general bucket delete request so we might
want to be careful how we handle this field on existing object store buckets
Since bucket delete with recursive = true on a non-FSO bucket is the only
case where this flag does not make sense, a not supported operation error from
the server seems logical here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
