JyotinderSingh commented on a change in pull request #3227:
URL: https://github.com/apache/ozone/pull/3227#discussion_r833726910



##########
File path: 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
##########
@@ -1455,6 +1458,9 @@ public void testRenameFile() throws Exception {
     assertTrue("Renamed failed: /dir/file1", getFs().exists(file1Destin));
     FileStatus[] fStatus = getFs().listStatus(dirPath);
     assertEquals("Renamed failed", 1, fStatus.length);
+
+    // We cannot delete a non-empty bucket.
+    getFs().delete(dirPath, true);

Review comment:
       It seems like this is currently needed for the FSO variant of this test 
(since recursive behaviour is not being followed correctly for FSO). I will add 
a check for the bucket layout and delete these directories in the FSO case.
   We can remove that condition once the behaviour is fixed.
   Does this approach sound good?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to