lokeshj1703 commented on a change in pull request #3222:
URL: https://github.com/apache/ozone/pull/3222#discussion_r834137237
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -461,24 +460,19 @@ public static XceiverServerRatis newXceiverServerRatis(
// configuration for both.
private static Parameters createTlsParameters(SecurityConfig conf,
CertificateClient caClient) throws IOException {
- Parameters parameters = new Parameters();
-
if (conf.isSecurityEnabled() && conf.isGrpcTlsEnabled()) {
List<X509Certificate> caList = HAUtils.buildCAX509List(caClient,
conf.getConfiguration());
GrpcTlsConfig serverConfig = new GrpcTlsConfig(
caClient.getPrivateKey(), caClient.getCertificate(),
caList, true);
- GrpcConfigKeys.Server.setTlsConf(parameters, serverConfig);
- GrpcConfigKeys.Admin.setTlsConf(parameters, serverConfig);
-
GrpcTlsConfig clientConfig = new GrpcTlsConfig(
caClient.getPrivateKey(), caClient.getCertificate(),
caList, false);
- GrpcConfigKeys.Client.setTlsConf(parameters, clientConfig);
+ return RatisHelper.setServerTlsConf(serverConfig, clientConfig);
}
- return parameters;
+ return null;
Review comment:
I was actually wondering that UT should have failed if this was the case.
I misunderstood the code in RaftServer#build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
