adoroszlai opened a new pull request #3234:
URL: https://github.com/apache/ozone/pull/3234


   ## What changes were proposed in this pull request?
   
   Fix TestContainerStateManagerIntegration:
   
    * Set pipeline limit, as the test assumes single pipeline per datanode 
(which used to be the default).
    * `testReplicaMap` had a consistent `fail()` call, which used to be part of 
a try-catch block where exception was expected before HDDS-5607.
    * Remove two test cases that were testing the same code path as others due 
to always passing an empty set of excluded container IDs.
    * Use a fixed thread pool for `testGetMatchingContainerMultipleThreads`.  
It was failing in CI with `unable to create new native thread`, because 
[`supplyAsync` launches a new thread for each task when parallelism is 
1](https://issues.apache.org/jira/browse/RATIS-1497?focusedCommentId=17480241&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17480241).
       ```
       java.lang.OutOfMemoryError: unable to create new native thread
         at java.lang.Thread.start0(Native Method)
         at java.lang.Thread.start(Thread.java:719)
         at 
java.util.concurrent.CompletableFuture$ThreadPerTaskExecutor.execute(CompletableFuture.java:405)
         at 
java.util.concurrent.CompletableFuture.asyncSupplyStage(CompletableFuture.java:1618)
         at 
java.util.concurrent.CompletableFuture.supplyAsync(CompletableFuture.java:1827)
         at 
org.apache.hadoop.hdds.scm.container.TestContainerStateManagerIntegration.testGetMatchingContainerMultipleThreads(TestContainerStateManagerIntegration.java:294)
       ```
   
   https://issues.apache.org/jira/browse/HDDS-6505
   
   ## How was this patch tested?
   
   Repeated 50x without the flaky `testGetMatchingContainerMultipleThreads`:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/2034074566
   
   Regular CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/2034107910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to