smengcl commented on a change in pull request #3177:
URL: https://github.com/apache/ozone/pull/3177#discussion_r834858343
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantRequestHelper.java
##########
@@ -182,8 +184,10 @@ public static boolean isUserAccessIdPrincipalOrTenantAdmin(
return true;
}
- // Check if ugi is an admin of this tenant
- if (ozoneManager.isTenantAdmin(ugi, tenantId, true)) {
+ // Check if ugi is a tenant admin (or an Ozone cluster admin)
+ final OMMultiTenantManager multiTenantManager =
+ ozoneManager.getMultiTenantManager();
+ if (multiTenantManager.isTenantAdmin(ugi, tenantId, true)) {
Review comment:
Note that when set to false, a non-delegated tenant admin could also
SetSecret of a delegated tenant admin.
This should not pose a security issue though, as the AccessId/Key pair is
only used to grant access to the volume from S3 Gateway, but not any other
administrative tasks that requires CLI access (that requires separate Kerberos
auth).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
