siddhantsangwan commented on a change in pull request #3153:
URL: https://github.com/apache/ozone/pull/3153#discussion_r839291074
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java
##########
@@ -331,7 +332,8 @@ Pipeline
createReplicationPipeline(HddsProtos.ReplicationType type,
/**
* Start ContainerBalancer.
*/
- boolean startContainerBalancer(Optional<Double> threshold,
+ StartContainerBalancerResponseProto startContainerBalancer(
Review comment:
I just realised this - changing the method return type here would make
this backward incompatible, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
