adoroszlai edited a comment on pull request #3259: URL: https://github.com/apache/ozone/pull/3259#issuecomment-1084638669
> Ozone Token Renewer's are implemented in [BasicOzoneClientAdapterImpl.java#L401](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java#L401) and [BasicRootedOzoneClientAdapterImpl.java#L830](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java#L830) , which are not present in the ozone-filesystem-hadoop3-*.jar fat jar. Can you please explain why you think these are not present? I see them in both 1.2.0 release: ``` unzip -t ozone-1.2.0/share/ozone/lib/ozone-filesystem-hadoop3-1.2.0.jar | grep Renewer testing: org/apache/hadoop/hdds/security/token/OzoneBlockTokenIdentifier$Renewer.class OK testing: org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl$Renewer.class OK testing: org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl$Renewer.class OK ``` and in current `master`: ``` unzip -t hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT/share/ozone/lib/ozone-filesystem-hadoop3-1.3.0-SNAPSHOT.jar | grep Renewer testing: org/apache/hadoop/hdds/security/token/OzoneBlockTokenIdentifier$Renewer.class OK testing: org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl$Renewer.class OK testing: org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl$Renewer.class OK ``` I guess you mean the `META-INF/services/org.apache.hadoop.security.*` files are missing. The patch has failure in MR acceptance test with Hadoop 2.7: ``` NoClassDefFoundError: org/apache/hadoop/crypto/key/KeyProviderTokenIssuer ... at org.apache.hadoop.fs.FileSystem.loadFileSystems(FileSystem.java:2631) at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2650) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2667) at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:94) at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2703) at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2685) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:373) at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295) at org.apache.hadoop.fs.shell.PathData.expandAsGlob(PathData.java:325) at org.apache.hadoop.fs.shell.CommandWithDestination.getRemoteDestination(CommandWithDestination.java:188) at org.apache.hadoop.fs.shell.CopyCommands$Put.processOptions(CopyCommands.java:237) at org.apache.hadoop.fs.shell.Command.run(Command.java:164) at org.apache.hadoop.fs.FsShell.run(FsShell.java:287) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84) at org.apache.hadoop.fs.FsShell.main(FsShell.java:340) ``` Instead of adding `ozone-filesystem` as a dependency for `ozonefs-shaded`, I think the security-related descriptors should be copied to `hadoop-ozone/ozonefs-hadoop3/src/main/resources/META-INF/services`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
