errose28 commented on a change in pull request #3177:
URL: https://github.com/apache/ozone/pull/3177#discussion_r840948807
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantCreateRequest.java
##########
@@ -292,27 +291,27 @@ public OMClientResponse validateAndUpdateCache(
// Create tenant
// Add to tenantStateTable. Redundant assignment for clarity
final String bucketNamespaceName = volumeName;
- final List<String> policyNamesList = new ArrayList<>();
// Populate policy ID list
- // TODO: Check if both policies are actually used. Remove if not
- policyNamesList.add(tenantDefaultPolicies);
- final String bucketPolicyGroupName =
- tenantId + OzoneConsts.DEFAULT_TENANT_BUCKET_POLICY_SUFFIX;
+ final String bucketNamespacePolicyName =
+ OMMultiTenantManager.getDefaultBucketNamespacePolicyName(tenantId);
final String bucketPolicyName =
- bucketPolicyGroupName +
OzoneConsts.DEFAULT_TENANT_POLICY_NAME_SUFFIX;
- policyNamesList.add(bucketPolicyName);
-
- final OmDBTenantState omDBTenantInfo = new OmDBTenantState(
- tenantId, bucketNamespaceName, policyNamesList);
+ OMMultiTenantManager.getDefaultBucketNamespacePolicyName(tenantId);
Review comment:
Should be `OMMultiTenantManager.getDefaultBucketPolicyName(tenantId);`?
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOMMultiTenantManagerImpl.java
##########
@@ -65,18 +62,22 @@ public void setUp() throws IOException {
OMMetadataManager omMetadataManager = new OmMetadataManagerImpl(conf);
final String bucketNamespaceName = tenantName;
-
- // Note: policyNames is initialized with an empty list here.
- // Expand if needed.
- final OmDBTenantState omDBTenantInfo = new OmDBTenantState(
- tenantName, bucketNamespaceName, new ArrayList<>());
-
- omMetadataManager.getTenantStateTable().put(tenantName, omDBTenantInfo);
+ final String bucketNamespacePolicyName =
+ OMMultiTenantManager.getDefaultBucketNamespacePolicyName(tenantName);
+ final String bucketPolicyName =
+ OMMultiTenantManager.getDefaultBucketNamespacePolicyName(tenantName);
Review comment:
Same as above, this looks like it should be
`OMMultiTenantManager.getDefaultBucketPolicyName(tenantName);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
