rakeshadr commented on code in PR #3265:
URL: https://github.com/apache/ozone/pull/3265#discussion_r841672067
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMKeyRequestFactory.java:
##########
@@ -66,43 +55,56 @@ public static OMKeyRequest createRequest(OMRequest
omRequest,
switch (cmdType) {
case CreateDirectory:
Review Comment:
As per the online discussion with @JyotinderSingh the idea came to remove
the OmKeyReqFactory and can replace the check like below:
```
case CreateDirectory:
keyArgs = omRequest.getCreateDirectoryRequest().getKeyArgs();
volName = keyArgs.getVolumeName();
buckName = keyArgs.getBucketName();
break;
```
and has to do for all the key cmds.
Also, below cmds can be moved out of the factory becoz they don't follow the
patterns of reading bucketLayout from DB.
```
case PurgeKeys:
return new OMKeyPurgeRequest(omRequest);
case PurgePaths:
return new OMPathsPurgeRequestWithFSO(omRequest);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
