symious commented on PR #3252: URL: https://github.com/apache/ozone/pull/3252#issuecomment-1095162514
@adoroszlai Thank you for the detailed review. Fixed with the comments except the default value one. I was thinking to compare the value with defaultValue, but seems it's possible for users to use a value same as defaultValue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
