xBis7 opened a new pull request, #3294:
URL: https://github.com/apache/ozone/pull/3294

   ## What changes were proposed in this pull request?
   
   The Recon/api/NSSummaryEndpoint class so far has been handling only FSO 
buckets. 
   
   Keeping the class as it is, makes it very difficult to make an 
implementation for non FSO buckets as well. 
   
   We refactored the code to make it more readable, keep in NSSummaryEndpoint 
only the methods that are shared between classes and facilitate integrating 
code that accesses the KeyTable. 
   
   We moved out of the file all the methods used by FSO and nonFSO buckets so 
that later on we can add new classes without having to make large changes in 
NSSummaryEndpoint. 
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-5504
   
   https://issues.apache.org/jira/browse/HDDS-5505
   
   ## How was this patch tested?
   
   All unit tests are still passing. We also created a script for replacing the 
code of NSSummaryEndpoint with the one from the newly created classes. After 
that we used IntelliJ IDE diff tool to visualize the differences between the 
two classes and check whether we made any mistakes or serious changes during 
the refactoring. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to