umamaheswararao commented on code in PR #3293:
URL: https://github.com/apache/ozone/pull/3293#discussion_r848508969
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneShellHA.java:
##########
@@ -141,9 +141,6 @@ public static void init() throws Exception {
testFile.getParentFile().mkdirs();
testFile.createNewFile();
Review Comment:
is there a reason we want to initialize for every test now? ( init is
annotated as @beforeclass. )
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientUtils.java:
##########
@@ -165,7 +165,7 @@ public static ReplicationConfig
getClientConfiguredReplicationConfig(
*/
public static ReplicationConfig validateAndGetClientReplicationConfig(
ReplicationType userPassedType, String userPassedReplication,
- OzoneConfiguration clientSideConfig) {
Review Comment:
Can we update in resolveClientSideReplicationConfig also ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
