errose28 commented on PR #3286: URL: https://github.com/apache/ozone/pull/3286#issuecomment-1097573039
> As @sodonnel said, to prevent users writing large keys to DDOS the cluster, we still need to calculate usedBytes while allocate block I think my explanation for this part may have been confusing. I meant that we would still have a check in allocate block against the quota, and fail the allocation if it caused the current open key size to be larger than the quota. This prevents writing large keys exceeding the quota. This is still a quota check, but it is only a check against already committed data, not open uncommitted data. > We can also check if there is an Open keys, and if there is, the bucket is not allowed to be deleted. I'm not sure this is a good idea. Open keys are internal to the OM, and should not block other user operations, whether that is a bucket delete or a block allocate. Only committed data that is visible to the user (like committed keys) should prevent user operations. > About the problem of writing small files requires at least 3* blocks. I see HDFS also requires at least 3* blocks. So we can be consistent with HDFS and ignore this problem. +1 for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
