kerneltime commented on code in PR #3302:
URL: https://github.com/apache/ozone/pull/3302#discussion_r852389134
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/metrics/TestS3GatewayMetrics.java:
##########
@@ -272,11 +273,367 @@ public void testPutAclFailure() throws Exception {
assertEquals(1L, curMetric - oriMetric);
}
+
Review Comment:
These tests are good but not sufficient. There are multiple failure paths
possible and I do not think these test cases insures all the failure paths
result in metrics being updated correctly. I would also add (or replace) to
these tests but adding metrics check where the API is being tested. So when an
API test expects a success/failure one of the asserts includes check for metric
increments appropriately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
