guihecheng commented on PR #3292: URL: https://github.com/apache/ozone/pull/3292#issuecomment-1102167334
Hi @ChenSammi , I've made a new push just now. Comments address check list: - [ ] ozone-default description - [ ] shutdown dbVolumeSet - [ ] nodeReport for dbVolumeSet - [ ] VERSION file logic extracted into a common place StorageVolume, so DbVolume now has VERSION file - [ ] dbParentDir is only set at the end of the function - [ ] a config switch for schemaV3 with a helper function to check it - [ ] tests check that no duplicate db instance will be created on dbVolume failures. - [ ] Some renames like formatXXX -> createXXX Apart from the comments above, I've make some refactors to keep related things together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
