adoroszlai commented on PR #3104: URL: https://github.com/apache/ozone/pull/3104#issuecomment-1102502395
Sorry for being late here. Why was the new annotation added in a completely separate project in `dev-support`? We already have custom annotations defined in regular submodules used in other ones. 1.`dev-support` usually contains stuff that is useful but not necessary for the project to work. This is not the case here. 2. It requires duplicate definition of few dependencies and checks (checkstyle, spotbugs, etc.). 3. Versioning and release process is not clear. `versions:set` needs to be applied separately to this module (see #3317). This may break downstream builds. I would guess the jar also needs to be uploaded to Nexus separately during release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
