kerneltime commented on code in PR #3252: URL: https://github.com/apache/ozone/pull/3252#discussion_r853426793
########## hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/ClientIpFilter.java: ########## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.s3; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.Priority; +import javax.servlet.http.HttpServletRequest; +import javax.ws.rs.container.ContainerRequestContext; +import javax.ws.rs.container.ContainerRequestFilter; +import javax.ws.rs.container.PreMatching; +import javax.ws.rs.core.Context; +import javax.ws.rs.ext.Provider; +import java.io.IOException; + +/** + * Filter used to get ClientIP from HttpServletRequest. + */ + +@Provider +@PreMatching +@Priority(ClientIpFilter.PRIORITY) +public class ClientIpFilter implements ContainerRequestFilter { + + public static final int PRIORITY = 200; + + public static final String CLIENT_IP_HEADER = "client_ip"; + + private static final Logger LOG = LoggerFactory.getLogger( + ClientIpFilter.class); + + @Context + private HttpServletRequest httpServletRequest; + + @Override + public void filter(ContainerRequestContext request) throws IOException { + String clientIp = httpServletRequest.getHeader("x-real-ip"); + + if (clientIp == null || clientIp.isEmpty()) { + // extract from forward ips + String ipForwarded = httpServletRequest.getHeader("x-forwarded-for"); Review Comment: What is the rational for picking `x-real-ip` first before `x-forwarded-for` For the purpose of auditing it might make sense to include both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
