adoroszlai opened a new pull request, #3330:
URL: https://github.com/apache/ozone/pull/3330

   ## What changes were proposed in this pull request?
   
   Shaded Ozone FS jars currently include Hadoop Thirdparty libs:
   
   ```
   $ cd hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT/share/ozone/lib
   $ unzip -t ozone-filesystem-hadoop3-1.3.0-SNAPSHOT.jar | grep 
'org.apache.hadoop.thirdparty.*class' | sort | head
       testing: 
org/apache/hadoop/thirdparty/protobuf/AbstractMessage$Builder.class   OK
       testing: 
org/apache/hadoop/thirdparty/protobuf/AbstractMessage$BuilderParent.class   OK
       testing: org/apache/hadoop/thirdparty/protobuf/AbstractMessage.class   OK
       testing: 
org/apache/hadoop/thirdparty/protobuf/AbstractMessageLite$Builder$LimitedInputStream.class
   OK
       testing: 
org/apache/hadoop/thirdparty/protobuf/AbstractMessageLite$Builder.class   OK
       testing: org/apache/hadoop/thirdparty/protobuf/AbstractMessageLite.class 
  OK
       testing: org/apache/hadoop/thirdparty/protobuf/AbstractParser.class   OK
       testing: 
org/apache/hadoop/thirdparty/protobuf/AbstractProtobufList.class   OK
       testing: org/apache/hadoop/thirdparty/protobuf/Android.class   OK
       testing: org/apache/hadoop/thirdparty/protobuf/Any$1.class   OK
   ```
   
   This can result in version mismatch if the FS jars are used with different 
Hadoop version than the one we package with (3.3.1 currently).
   
   This PR makes Hadoop Thirdparty libs to be excluded, letting users provide 
it, similar to regular Hadoop libs (hadoop-common, hadoop-hdfs-client, etc.).
   
   https://issues.apache.org/jira/browse/HDDS-6626
   
   ## How was this patch tested?
   
   ```
   $ cd hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT/share/ozone/lib
   $ unzip -t ozone-filesystem-hadoop3-1.3.0-SNAPSHOT.jar | grep -c 
'org.apache.hadoop.thirdparty'
   0
   ```
   
   Functionality is tested by existing acceptance test in `ozone-mr` env.
   
   https://github.com/adoroszlai/hadoop-ozone/runs/6115327106


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to