[
https://issues.apache.org/jira/browse/HDDS-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528916#comment-17528916
]
Neil Joshi commented on HDDS-6433:
----------------------------------
Hi [~hanishakoneru] , thanks for this. I've overlooked this comment
unfortunately prior to calling to merge the feature branch to the master. I
apologize. I discussed doing this Jira issue and submitting it into the master
branch after the merge in a few community meetings and was under the impression
that it would be alright to do so.
I will be updating this Jira shortly with a patch for refactoring the
OMFailoverProxyProvider as you suggested. Thanks!
> Refactor OMFailoverProxyProvider to provide a base for OM and GrpcOM
> FailoverProxyProviders
> -------------------------------------------------------------------------------------------
>
> Key: HDDS-6433
> URL: https://issues.apache.org/jira/browse/HDDS-6433
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Neil Joshi
> Priority: Major
>
> HDDS-5544 added GrpcOMFailoverProxyProvider which implements
> OMFailoverProxyProvider but it does not need most of the logic in
> OMFailoverProxyProvider and sets some map values as null as it is not
> required for Grpc.
> For keeping the same underlying failover proxy, instead of
> GrpcOMFailoverProxyProvider implementing OMFailoverProxyProvider, there
> should be a base interface/ class that these two can can implement.
> Please refer to
> [this|https://github.com/apache/ozone/pull/2901#issuecomment-1058492345]
> comment in HDDS-5544.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
