sodonnel opened a new pull request, #3359: URL: https://github.com/apache/ozone/pull/3359
## What changes were proposed in this pull request? ``` TestBackgroundPipelineScrubber.testRun() fails intermittently for me locally, with this trace: 2022-04-27 17:20:44,888 [main] INFO pipeline.BackgroundPipelineScrubber (BackgroundPipelineScrubber.java:start(123)) - Starting Pipeline Scrubber Service. 2022-04-27 17:20:44,890 [main] INFO pipeline.BackgroundPipelineScrubber (BackgroundPipelineScrubber.java:notifyStatusChanged(85)) - Service BackgroundPipelineScrubber transitions to RUNNING. 2022-04-27 17:20:47,905 [main] INFO pipeline.BackgroundPipelineScrubber (BackgroundPipelineScrubber.java:stop(140)) - Stopping Pipeline Scrubber Service. 2022-04-27 17:20:47,905 [PipelineScrubberThread] WARN pipeline.BackgroundPipelineScrubber (BackgroundPipelineScrubber.java:run(158)) - PipelineScrubberThread is interrupted, exit Wanted but not invoked: pipelineManager.scrubPipelines(); -> at org.apache.hadoop.hdds.scm.pipeline.TestBackgroundPipelineScrubber.testRun(TestBackgroundPipelineScrubber.java:97) Actually, there were zero interactions with this mock. Wanted but not invoked: pipelineManager.scrubPipelines(); -> at org.apache.hadoop.hdds.scm.pipeline.TestBackgroundPipelineScrubber.testRun(TestBackgroundPipelineScrubber.java:97) Actually, there were zero interactions with this mock. ``` I believe the reason is that when the `notifyStatusChanged()` method is called, the thread may be running and not waiting. Then calling notifyAll() does not do anything. The thread will fall into the wait and stay stuck there until the wait interval expires, or another notify() call is received. I think the test can be made to run reliably by using a volatile boolean to skip the wait along with the notify. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-6661 ## How was this patch tested? Modified unit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
