smengcl commented on code in PR #3131: URL: https://github.com/apache/ozone/pull/3131#discussion_r861347779
########## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/multitenant/AccessPolicy.java: ########## @@ -18,6 +18,7 @@ Review Comment: I attempted and figured it would be another >500 lines of +/- if we move the whole logic from AccessPolicy to MultiTenantAccessController in this PR. The roleList addition in AccessPolicy is inserted into existing logic and we had to move a whole bunch of existing code to avoid adding code to AccessPolicy in this PR. I suggest we do the refactoring in another separate PR for easier review. Plus `MultiTenantAccessController` is not even initiated anywhere before. I added its init in `MultiTenantAccessAuthorizerRangerPlugin#init` and not sure if it is the intended usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
