[
https://issues.apache.org/jira/browse/HDDS-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530407#comment-17530407
]
Kaijie Chen commented on HDDS-6400:
-----------------------------------
Hi [~umamaheswararao], I have resubmitted PR at
[https://github.com/apache/ozone/pull/3372].
I have reorganized the commits into logic pieces to make the review easier.
The PR was submitted as draft because I believe there are several places still
can be improved.
Please leave comments for the current changes if you have time.
> EC: Refactor ECKeyOutputStream for better code reuse
> ----------------------------------------------------
>
> Key: HDDS-6400
> URL: https://issues.apache.org/jira/browse/HDDS-6400
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Kaijie Chen
> Assignee: Kaijie Chen
> Priority: Major
> Labels: pull-request-available
>
> Refactor ECKeyOutputStream to make the code cleaner.
> Reuse code when writing the last stripe or rewriting failed stripes.
> The changes includes:
> # handleDataWrite() has been changed to handleWrite(),
> it will check strip full and call encodeAndWriteParityCells().
> # checkAndWriteParityCells() has been changed to encodeAndWriteParityCells(),
> and it can be reused to encode partial stripe in close().
> # handleParityWrites() has seperated generateParityCells(),
> it can be reused in rewriteStripeToNewBlockGroup().
> # handleFailedStreams() has been changed to excludePipelineAndFailedDN(),
> it will exclude both failed pipeline and failed datanodes.
> # Reuse handleOutputStreamWrite() in close()
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
