[
https://issues.apache.org/jira/browse/HDDS-6688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-6688:
-----------------------------------
Description:
To insure that all code paths while executing S3 APIs, the corresponding
metrics are correctly updated, it is important to check metrics for all API
tests.
* Move newly added metrics _assertions_ to the corresponding test cases in
endpoint/operation-specific test classes under
{{hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint}}.
* Move complete test method if no corresponding test case exists
* Make sure all scenarios have metrics assertions
This is coming out of a review comment here:
https://github.com/apache/ozone/pull/3302#discussion_r852883766
was:
To insure that all code paths while executing S3 APIs, the corresponding
metrics are correctly updated, it is important to check metrics for all API
tests.
This is coming out of a review comment here:
https://github.com/apache/ozone/pull/3302#discussion_r852883766
> S3G API tests should validate metrics in addition to metric specific testing
> ----------------------------------------------------------------------------
>
> Key: HDDS-6688
> URL: https://issues.apache.org/jira/browse/HDDS-6688
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: S3
> Reporter: Ritesh H Shukla
> Priority: Major
> Labels: newbie
>
> To insure that all code paths while executing S3 APIs, the corresponding
> metrics are correctly updated, it is important to check metrics for all API
> tests.
> * Move newly added metrics _assertions_ to the corresponding test cases in
> endpoint/operation-specific test classes under
> {{hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint}}.
> * Move complete test method if no corresponding test case exists
> * Make sure all scenarios have metrics assertions
> This is coming out of a review comment here:
> https://github.com/apache/ozone/pull/3302#discussion_r852883766
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
