errose28 commented on code in PR #3377:
URL: https://github.com/apache/ozone/pull/3377#discussion_r864358504
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##########
@@ -393,4 +393,52 @@ public static OMRequest
disallowCreateBucketWithECReplicationConfig(
}
return req;
}
+
+ @RequestFeatureValidator(
+ conditions = ValidationCondition.CLUSTER_NEEDS_FINALIZATION,
+ processingPhase = RequestProcessingPhase.PRE_PROCESS,
+ requestType = Type.CreateBucket
+ )
+ public static OMRequest
disallowCreateBucketWithBucketLayoutDuringPreFinalize(
+ OMRequest req, ValidationContext ctx) throws OMException {
+ if (!ctx.versionManager()
+ .isAllowed(OMLayoutFeature.BUCKET_LAYOUT_SUPPORT)) {
+ if (req.getCreateBucketRequest()
+ .getBucketInfo().hasBucketLayout()
+ &&
+ !BucketLayout.fromProto(req.getCreateBucketRequest().getBucketInfo()
+ .getBucketLayout()).isLegacy()) {
+ throw new OMException("Cluster does not have the Bucket Layout"
+ + " support feature finalized yet, but the request contains"
+ + " a non LEGACY bucket type. Rejecting the request,"
+ + " please finalize the cluster upgrade and then try again.",
+
OMException.ResultCodes.NOT_SUPPORTED_OPERATION_PRIOR_FINALIZATION);
+ }
+ }
+ return req;
+ }
+
+ @RequestFeatureValidator(
+ conditions = ValidationCondition.OLDER_CLIENT_REQUESTS,
Review Comment:
I don't think this is needed yet. It will probably be easier to handle all
client cross compatibility in its own PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
