kaijchen commented on code in PR #3226:
URL: https://github.com/apache/ozone/pull/3226#discussion_r866426909
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -585,6 +587,12 @@ public String getOpenKey(String volume, String bucket,
return openKey;
}
+ private static long getClientID(String dbOpenKeyName) {
+ int beginIndex = dbOpenKeyName.lastIndexOf(OM_KEY_PREFIX) + 1;
+ String clientID = dbOpenKeyName.substring(beginIndex);
+ return Long.parseLong(clientID);
Review Comment:
In proto it is `uint64`, and it's also `long` in
`OMMetadataManager.getOpenKey` and `getOpenFileName`.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -585,6 +587,12 @@ public String getOpenKey(String volume, String bucket,
return openKey;
}
+ private static long getClientID(String dbOpenKeyName) {
+ int beginIndex = dbOpenKeyName.lastIndexOf(OM_KEY_PREFIX) + 1;
+ String clientID = dbOpenKeyName.substring(beginIndex);
+ return Long.parseLong(clientID);
Review Comment:
In proto it is `uint64`, maybe we can just get rid of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
