rakeshadr commented on PR #3379:
URL: https://github.com/apache/ozone/pull/3379#issuecomment-1119495229
> @kaijchen @umamaheswararao @rakeshadr @kerneltime Thanks everyone for the
review. As per @kaijchen last comment, it is correct. Since it is sorted even
if we take the cached keys that are out-of-bound for that batch. As we iterate
to the DB these out-of-bound keys will be pushed to the last in TreeMap. As a
result in the final `fileStatusFinalList` we truncate these keys as they are
out of bound.
@kaijchen , @aswinshakil +1 Agreed with the proposal. Appreciate if you
could add test case to cover the example that we discussed, listing across
batches with cached keypaths.
Probably, you can write test case into **TestKeyManagerImpl** suite and you
can add cache entry like below:
```
omMetadataManager.getOpenKeyTable(BucketLayout)
.addCacheEntry(new CacheKey<>(ozoneKey),
new CacheValue<>(Optional.of(omKeyInfo), trxnLogIndex));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
