errose28 commented on code in PR #3233:
URL: https://github.com/apache/ozone/pull/3233#discussion_r867187263
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1027,6 +1027,7 @@ message OpenKeyBucket {
message OpenKey {
required string name = 1;
required uint64 clientID = 2;
+ optional uint64 parentID = 3;
Review Comment:
Lets make the proto changes in #3226 and merge that first, then update this
PR with the new proto.
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMOpenKeysDeleteRequest.java:
##########
@@ -60,8 +53,21 @@ public class TestOMOpenKeysDeleteRequest extends
TestOMKeyRequest {
*/
@Test
public void testDeleteOpenKeysNotInTable() throws Exception {
- OpenKeyBucket openKeys = makeOpenKeys(volumeName, bucketName, 5);
- deleteOpenKeysFromCache(openKeys);
+ testDeleteOpenKeysNotInTable(BucketLayout.DEFAULT);
Review Comment:
Can we use junit4 test parameterization for the test classes changed in this
PR instead of adding a new test method for each bucket layout?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java:
##########
@@ -106,15 +106,14 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
}
omClientResponse = new OMOpenKeysDeleteResponse(omResponse.build(),
- deletedOpenKeys, updatedBuckets, ozoneManager.isRatisEnabled());
+ deletedOpenKeys, updatedBuckets, ozoneManager.isRatisEnabled(),
+ getBucketLayout());
Review Comment:
With the proto update from #3226, the bucket type in the request will need
to be used here, since the bucket may no longer exist at this point. I think
that change will have more effects on this class as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
