kerneltime commented on code in PR #3387:
URL: https://github.com/apache/ozone/pull/3387#discussion_r867268365
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3297,6 +3297,7 @@ TermIndex installCheckpoint(String leaderId, Path
checkpointLocation,
if (canProceed) {
// Stop RPC server before stop metadataManager
omRpcServer.stop();
+ omRpcServer.join();
Review Comment:
Is this needed?
`Server.java`
```
public synchronized void stop() {
LOG.info("Stopping server on " + this.port);
this.running = false;
if (this.handlers != null) {
for(int i = 0; i < this.handlerCount; ++i) {
if (this.handlers[i] != null) {
this.handlers[i].interrupt();
}
}
}
this.listener.interrupt();
this.listener.doStop();
this.responder.interrupt();
this.notifyAll();
this.rpcMetrics.shutdown();
this.rpcDetailedMetrics.shutdown();
}
```
and
```
public synchronized void join() throws InterruptedException {
while(this.running) {
this.wait();
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
