rakeshadr commented on code in PR #3201:
URL: https://github.com/apache/ozone/pull/3201#discussion_r871642600
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -814,6 +814,41 @@ message KeyLocationList {
optional bool isMultipartKey = 4 [default = false];
}
+/**
+ * Checksum algorithms/types used in Ozone
+ * Make sure this enum's integer values match enum values' id properties
defined
+ * in org.apache.hadoop.util.DataChecksum.Type
+ */
+enum ChecksumTypeProto {
+ CHECKSUM_NULL = 0;
+ CHECKSUM_CRC32 = 1;
+ CHECKSUM_CRC32C = 2;
+}
+
+enum FileChecksumTypeProto {
+ COMPOSITE_CRC = 1; // Chunk-independent CRC, optionally striped
+ MD5CRC = 2; // BlockChecksum obtained by taking the MD5 digest of chunk CRCs
Review Comment:
@ChenSammi yes, intentionally made the default to composite and the order is
different from HDFS. We would like to keep the composite as default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
