guihecheng commented on code in PR #3392:
URL: https://github.com/apache/ozone/pull/3392#discussion_r871976413
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -114,9 +117,8 @@ public void createWorkingDir(String workingDirName,
MutableVolumeSet dbVolumeSet) throws IOException {
super.createWorkingDir(workingDirName, dbVolumeSet);
- if (SchemaV3.isFinalizedAndEnabled(getConf())) {
- createDbStore(dbVolumeSet);
- }
+ // Create DB store for a newly formatted volume
Review Comment:
But then we are using part of the un-finalized feature logic before
finalizeUpgrade, conceptually, if it is OK for non-rolling upgrade feature, I'm
fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
