ChenSammi commented on code in PR #3382:
URL: https://github.com/apache/ozone/pull/3382#discussion_r871980621
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java:
##########
@@ -158,7 +158,7 @@ private OMResponse processRequest(OMRequest request) throws
// if current OM is leader and then proceed with processing the
request.
if (request.hasS3Authentication()) {
s3Auth = true;
- checkLeaderStatus();
+ OzoneManagerRatisUtils.checkLeaderStatus(ozoneManager);
S3SecurityUtil.validateS3Credential(request, ozoneManager);
}
Review Comment:
Correct me if I'm wrong. With HDDS-4440 and HDDS-5881, S3 authentication
will be carried as part of the OMRequest. It doesn't leverage the underline
hadoop RPC SASL authentication, and these requests will not be processed by
SASL. So the leader check is still needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
