guihecheng commented on code in PR #3398: URL: https://github.com/apache/ozone/pull/3398#discussion_r871983046
########## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBSstFileLoader.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdds.utils.db; + +import org.rocksdb.ColumnFamilyHandle; +import org.rocksdb.IngestExternalFileOptions; +import org.rocksdb.RocksDB; +import org.rocksdb.RocksDBException; + +import java.io.File; +import java.io.IOException; +import java.util.Collections; + +import static org.apache.hadoop.hdds.utils.HddsServerUtil.toIOException; + +/** + * DumpFileLoader using rocksdb sst files. + */ +public class RDBSstFileLoader implements DumpFileLoader { + + private final RocksDB db; + private final ColumnFamilyHandle handle; + private final IngestExternalFileOptions ingestOptions; + + + public RDBSstFileLoader(RocksDB db, ColumnFamilyHandle handle) { + this.db = db; + this.handle = handle; + this.ingestOptions = new IngestExternalFileOptions() Review Comment: We have multiple column families, so if the sst file carries the column family info and the ingest API knows it, then we could. But I think it doesn't. As I understand, this ingest multiple files API targets at the scenario that there are multiple sst files that could be ingested into the same column family at once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
